Skip to content

[Snyk] Fix for 18 vulnerabilities#5240

Closed
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-ab704984dbb70185f792d69c94e68cf6
Closed

[Snyk] Fix for 18 vulnerabilities#5240
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-ab704984dbb70185f792d69c94e68cf6

Conversation

@snyk-io
Copy link
Copy Markdown

@snyk-io snyk-io Bot commented May 20, 2025

snyk-top-banner

Snyk has created this PR to fix 18 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/catalog-backend-module-github/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Uncaught Exception
SNYK-JS-MULTER-10185673
  828  
critical severity Remote Code Execution (RCE)
SNYK-JS-MYSQL2-6591085
  811  
critical severity Arbitrary Code Injection
SNYK-JS-MYSQL2-6670046
  811  
critical severity Remote Code Execution (RCE)
SNYK-JS-JSONPATHPLUS-7945884
  786  
critical severity Remote Code Execution (RCE)
SNYK-JS-JSONPATHPLUS-8719585
  786  
high severity Prototype Pollution
SNYK-JS-MYSQL2-6861580
  731  
high severity Missing Release of Memory after Effective Lifetime
SNYK-JS-MULTER-10185675
  721  
high severity Denial of Service (DoS)
SNYK-JS-WS-7266574
  696  
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-OCTOKITPLUGINPAGINATEREST-8730855
  666  
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-OCTOKITREQUESTERROR-8730854
  666  
medium severity Prototype Poisoning
SNYK-JS-MYSQL2-6591084
  646  
medium severity Use of Web Browser Cache Containing Sensitive Information
SNYK-JS-MYSQL2-6591300
  646  
medium severity Server-side Request Forgery (SSRF)
SNYK-JS-REQUEST-3361831
  646  
medium severity Uncontrolled Resource Consumption ('Resource Exhaustion')
SNYK-JS-TAR-6476909
  646  
medium severity Prototype Pollution
SNYK-JS-TOUGHCOOKIE-5672873
  646  
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-FASTXMLPARSER-7573289
  559  
medium severity Concurrent Execution using Shared Resource with Improper Synchronization ('Race Condition')
SNYK-JS-AZUREIDENTITY-7246760
  489  
medium severity Resource Exhaustion
SNYK-JS-JOSE-6419224
  479  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Concurrent Execution using Shared Resource with Improper Synchronization ('Race Condition')
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Remote Code Execution (RCE)
🦉 More lessons are available in Snyk Learn

Summary by Sourcery

Upgrade specific Backstage dependencies in the GitHub catalog backend module to fixed versions to address Snyk-reported vulnerabilities.

Bug Fixes:

  • Upgrade @backstage/catalog-model to 0.1.1 to resolve security issues
  • Upgrade @backstage/plugin-catalog-backend to 2.0.0 to fix known vulnerabilities
  • Upgrade @backstage/plugin-catalog-common to 0.1.0 to mitigate reported risks

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented May 20, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@restack-app
Copy link
Copy Markdown

restack-app Bot commented May 20, 2025

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 20, 2025

Reviewer's Guide

Upgrades three Backstage package dependencies in the GitHub catalog backend module to fixed versions to resolve multiple vulnerabilities.

Entity Relationship Diagram of Updated Dependencies in package.json

erDiagram
    PACKAGE_JSON {
        string filePath "plugins/catalog-backend-module-github/package.json"
        string note "Dependencies updated by Snyk"
    }
    CATALOG_MODEL {
        string name "@backstage/catalog-model"
        string oldVersion "workspace:^"
        string newVersion "0.1.1"
    }
    CATALOG_BACKEND {
        string name "@backstage/plugin-catalog-backend"
        string oldVersion "workspace:^"
        string newVersion "2.0.0"
    }
    CATALOG_COMMON {
        string name "@backstage/plugin-catalog-common"
        string oldVersion "workspace:^"
        string newVersion "0.1.0"
    }

    PACKAGE_JSON ||--o{ CATALOG_MODEL : "updates dependency"
    PACKAGE_JSON ||--o{ CATALOG_BACKEND : "updates dependency"
    PACKAGE_JSON ||--o{ CATALOG_COMMON : "updates dependency"
Loading

File-Level Changes

Change Details Files
Updated Backstage dependency versions to fix vulnerabilities
  • Changed @backstage/catalog-model from workspace reference to version 0.1.1
  • Bumped @backstage/plugin-catalog-backend to 2.0.0
  • Bumped @backstage/plugin-catalog-common to 0.1.0
plugins/catalog-backend-module-github/package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@snyk-io
Copy link
Copy Markdown
Author

snyk-io Bot commented May 20, 2025

Snyk checks have failed. 1 issues have been found so far.

Icon Severity Issues
Critical 0
High 0
Medium 1
Low 0

security/snyk check is complete. 1 issues have been found. (View Details)

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Comment on lines +52 to +57
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-backend": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-backend": "2.0.0",
"@backstage/plugin-catalog-common": "0.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version pinning in this PR is concerning. Replacing workspace:^ references with fixed versions (0.1.1, 2.0.0, 0.1.0) appears problematic for several reasons:

  1. These version numbers are suspiciously low for established Backstage packages
  2. Pinning to specific versions rather than using workspace references breaks the monorepo dependency management
  3. This approach may introduce compatibility issues with other Backstage components

Before merging, please verify these versions against the current Backstage release cycle. The warning about failing to update yarn.lock further suggests these dependency changes may not be properly resolved.

Consider addressing the vulnerabilities through proper Backstage package updates rather than pinning to potentially incompatible versions.

Suggested change
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-backend": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-backend": "2.0.0",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-backend": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label May 27, 2025
@github-actions github-actions Bot closed this Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants